Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for Go's verification code. #1

Merged
merged 1 commit into from Feb 15, 2017
Merged

Add test for Go's verification code. #1

merged 1 commit into from Feb 15, 2017

Conversation

agl
Copy link
Contributor

@agl agl commented Feb 13, 2017

This attempts to be a strict pass/fail test and thus it categorises each
of the “WEAK-OK” cases. That involves matching the description strings,
which is unfortunate but currently unavoidable.

It does not yet pass, but will on Go master once [1] has landed.

[1] https://go-review.googlesource.com/#/c/36900/

This attempts to be a strict pass/fail test and thus it categorises each
of the “WEAK-OK” cases. That involves matching the description strings,
which is unfortunate but currently unavoidable.

It does not yet pass, but will on Go master once [1] has landed.

[1] https://go-review.googlesource.com/#/c/36900/
@JackOfMostTrades
Copy link
Contributor

Thanks Adam. I've thought about doing a little bit of refactoring to define test expectations better depending on intended client behaviors (e.g. whether or not IP name constraints are enforced at all, or whether the client ignores CN entirely when SAN is present), but in the mean time matching description strings works for me.

@JackOfMostTrades JackOfMostTrades merged commit 16b9fed into Netflix:master Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants