Leave alt screen on panic #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heaths
approved these changes
May 12, 2024
| impl Drop for TerminalManager { | ||
| fn drop(&mut self) { | ||
| disable_raw_mode().unwrap_or_else(|e| eprintln!("Error disabling raw mode: {:?}", e)); | ||
| execute!(self.terminal.backend_mut(), LeaveAlternateScreen) |
There was a problem hiding this comment.
Should swap this with the previous line, I think. Need to send the ANSI resource sequence before disabling raw mode - or at least before bailing if raw mode fails.
| execute!(stdout, EnterAlternateScreen)?; | ||
| let backend = CrosstermBackend::new(stdout); | ||
| let mut terminal = Terminal::new(backend)?; | ||
| terminal.clear()?; |
There was a problem hiding this comment.
Did you still need to do this? Wasn't sure why this was here anyway since you're switching to the alt buffer, so maybe it was just unnecessary?
There was a problem hiding this comment.
No, I didn't. I also removed the clear() from the Drop impl. It was incorrectly clearing the primary screen.
Move the terminal setup and cleanup logic to a new `TaskManager` struct. This struct is responsible for setting up the terminal and cleanup up when the program exits. Terminal cleanup will now happen on panic.
jfernandez
force-pushed
the
41-should-leave-alt-screen-in-panic-hook
branch
from
1ab8e9f
to
7ebd674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the terminal setup and cleanup logic to a new
TaskManagerstruct. This struct is responsible for setting up the terminal and cleanup up when the program exits. Terminal cleanup will now happen on panic.Closes #41