Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

fix ordering of params in isolated task queue producer #1973

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

apanicker-nflx
Copy link
Collaborator

@apanicker-nflx apanicker-nflx commented Nov 17, 2020

Fixes #1960

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #1973 (7a19487) into dev (6bce391) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1973      +/-   ##
============================================
+ Coverage     65.59%   65.85%   +0.25%     
- Complexity     3935     3977      +42     
============================================
  Files           301      301              
  Lines         18529    18742     +213     
  Branches       1686     1768      +82     
============================================
+ Hits          12155    12342     +187     
- Misses         5535     5557      +22     
- Partials        839      843       +4     
Impacted Files Coverage Δ Complexity Δ
...ore/execution/tasks/IsolatedTaskQueueProducer.java 72.72% <100.00%> (ø) 7.00 <0.00> (ø)
...ductor/dao/cassandra/CassandraEventHandlerDAO.java 65.78% <0.00%> (-10.53%) 15.00% <0.00%> (ø%)
.../conductor/dao/cassandra/CassandraMetadataDAO.java 55.44% <0.00%> (-4.15%) 25.00% <0.00%> (ø%)
...e/execution/tasks/SystemTaskWorkerCoordinator.java 81.25% <0.00%> (-2.09%) 17.00% <0.00%> (-1.00%)
...lix/conductor/core/execution/WorkflowExecutor.java 83.02% <0.00%> (+3.34%) 224.00% <0.00%> (+43.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bce391...7a19487. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4748

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 70.078%

Files with Coverage Reduction New Missed Lines %
cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraEventHandlerDAO.java 8 68.42%
cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java 8 55.44%
Totals Coverage Status
Change from base Build 4743: -0.09%
Covered Lines: 12982
Relevant Lines: 18525

💛 - Coveralls

@apanicker-nflx apanicker-nflx merged commit 90ab0ba into dev Nov 17, 2020
@apanicker-nflx apanicker-nflx deleted the isolated_task_queue_producer_fix branch November 17, 2020 00:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants