This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
feat: Add inputTemplate support to workflow metadata #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apanicker-nflx
approved these changes
Aug 30, 2021
ParametersUtilsTest and WorkflowAndTaskConfigurationSpec provide good coverage for this change. Thanks for adding the tests. |
aravindanr
approved these changes
Sep 8, 2021
| return inputTemplate; | ||
| } | ||
|
|
||
| public WorkflowDef setInputTemplate(Map<String, Object> inputTemplate) { |
There was a problem hiding this comment.
To keep it consistent with the other setters in the class, can this also return void?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
This adds an
inputTemplateconfiguration option to workflow definitions that functions similar to theinputTemplateon task definitions .My current workaround is to define a
jqtask to do things like provide default variables but this does so more elegantly and maps to the current task modelling.Alternatives considered
inputTemplateis consistent across tasks and workflows, but a new field could have been used here if we wanted to separate the implementationsQuestions