This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Fix NPE when header values are null #2949
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens to our workflow with optional headers
ghost
marked this pull request as draft
ghost
closed this
ghost
reopened this
ghost
marked this pull request as ready for review
|
@aravindanr @apanicker-nflx I fail to find a way to add you guys as reviewers. Please check this PR when you have time. |
|
@xstas The repo structure has changed and http-task is now housed in its own module. Please rebase and commit. |
|
@apanicker-nflx - I have created a new PR #2964 to fix the problem, I was unable to edit this PR. Can we mark this PR as wont fix and merge #2964 instead? |
|
Superseded by #2964 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens to our workflow with optional headers
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
Fix NPE when optional headers like below are not provided.
Alternatives considered
No alternatives considered