Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Fix for NPE when header values are null #2964

Merged
merged 2 commits into from
May 4, 2022
Merged

Conversation

muralicmr
Copy link
Contributor

@muralicmr muralicmr commented May 3, 2022

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
  • WHOSUSING.md
  • Other (please describe):

Changes in this PR

Fix NPE when optional headers like below are not provided.

"headers": {
    "header1": "${workflow.input.header1}"
}

Describe the new behavior from this PR, and why it's needed
Issue #2884
In the new version of conductor HTTP tasks fail with NPE is a header value is not provided. As HTTP task is generic it is a good practice to support header values which are defined in workflow but not sent while making a call to execute the workflow.
Also its good to note that this feature was working in 2.x version of conductor.

Alternatives considered

No alternatives considered

@apanicker-nflx apanicker-nflx added the type: bug bugs/ bug fixes label May 3, 2022
@apanicker-nflx
Copy link
Collaborator

Please run ./gradlew spotlessApply to fix formatting issues.

@apanicker-nflx apanicker-nflx merged commit 4e1f08a into Netflix:main May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug bugs/ bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants