Merge pull request #428 from lucatk/open-restcontrollers

Mark RestController attributes as open val to allow CGLIB proxying
Netflix · Jun 23, 2021 · c2ee949 · c2ee949
2 parents c0c74c3 + d383dd3
commit c2ee949
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/graphql-dgs-spring-webmvc/src/main/kotlin/com/netflix/graphql/dgs/mvc/DgsRestController.kt b/graphql-dgs-spring-webmvc/src/main/kotlin/com/netflix/graphql/dgs/mvc/DgsRestController.kt
@@ -60,9 +60,9 @@ import org.springframework.web.multipart.MultipartFile
  */
 
 @RestController
-open class DgsRestController(private val dgsQueryExecutor: DgsQueryExecutor) {
+open class DgsRestController(open val dgsQueryExecutor: DgsQueryExecutor) {
 
-    val logger: Logger = LoggerFactory.getLogger(DgsRestController::class.java)
+    open val logger: Logger = LoggerFactory.getLogger(DgsRestController::class.java)
 
     // The @ConfigurationProperties bean name is <prefix>-<fqn>
     @RequestMapping(

diff --git a/...-spring-webmvc/src/main/kotlin/com/netflix/graphql/dgs/mvc/DgsRestSchemaJsonController.kt b/...-spring-webmvc/src/main/kotlin/com/netflix/graphql/dgs/mvc/DgsRestSchemaJsonController.kt
@@ -33,7 +33,7 @@ import org.springframework.web.bind.annotation.RestController
  * Do not manually extend this class.
  */
 @RestController
-open class DgsRestSchemaJsonController(private val schemaProvider: DgsSchemaProvider) {
+open class DgsRestSchemaJsonController(open val schemaProvider: DgsSchemaProvider) {
 
     // The @ConfigurationProperties bean name is <prefix>-<fqn>
     @RequestMapping("#{@'dgs.graphql-com.netflix.graphql.dgs.webmvc.autoconfigure.DgsWebMvcConfigurationProperties'.schemaJson.path}", produces = ["application/json"])

diff --git a/...se/src/main/kotlin/com/netflix/graphql/dgs/subscriptions/sse/DgsSSESubscriptionHandler.kt b/...se/src/main/kotlin/com/netflix/graphql/dgs/subscriptions/sse/DgsSSESubscriptionHandler.kt
@@ -39,8 +39,8 @@ import java.util.*
  * Do not manually extend this class.
  */
 @RestController
-open class DgsSSESubscriptionHandler(private val dgsQueryExecutor: DgsQueryExecutor) {
-    private val logger = LoggerFactory.getLogger(DgsSSESubscriptionHandler::class.java)
+open class DgsSSESubscriptionHandler(open val dgsQueryExecutor: DgsQueryExecutor) {
+    open val logger = LoggerFactory.getLogger(DgsSSESubscriptionHandler::class.java)
 
     @RequestMapping("/subscriptions", produces = ["text/event-stream"])
     fun subscriptionWithId(@RequestParam("query") queryBase64: String): ResponseEntity<SseEmitter> {