Mark RestController attributes as open val to allow CGLIB proxying #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Following up #275, we discovered another small requirement for change in order to be able to use this library in combination with Spring AOP's CGLIB proxying.
As I know, it is not the purpose of these properties to be open, however we see CGLIB proxying as a dealbreaker in some large projects, and therefore would be very grateful if these changes could be incorporated to finally allow coexistence of DGS & AOP, seeing as this could benefit many others aswell, as this is a difficult cause of issue to explore.