Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark RestController attributes as open val to allow CGLIB proxying #428

Merged
merged 2 commits into from Jun 23, 2021
Merged

Mark RestController attributes as open val to allow CGLIB proxying #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b70ed8c
Define classes and properties of bean classes as open
lucatk May 4, 2021
d383dd3
Merge tag 'v4.2.0' into open-restcontrollers
lucatk Jun 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions graphql-dgs-spring-webmvc/src/main/kotlin/com/netflix/graphql/dgs/mvc/DgsRestController.kt
View file
Open in desktop
Expand Up @@ -60,9 +60,9 @@ import org.springframework.web.multipart.MultipartFile
*/

@RestController
open class DgsRestController(private val dgsQueryExecutor: DgsQueryExecutor) {
open class DgsRestController(open val dgsQueryExecutor: DgsQueryExecutor) {

val logger: Logger = LoggerFactory.getLogger(DgsRestController::class.java)
open val logger: Logger = LoggerFactory.getLogger(DgsRestController::class.java)

// The @ConfigurationProperties bean name is <prefix>-<fqn>
@RequestMapping(
Expand Down
2 changes: 1 addition & 1 deletion ...-spring-webmvc/src/main/kotlin/com/netflix/graphql/dgs/mvc/DgsRestSchemaJsonController.kt
View file
Open in desktop
Expand Up @@ -33,7 +33,7 @@ import org.springframework.web.bind.annotation.RestController
* Do not manually extend this class.
*/
@RestController
open class DgsRestSchemaJsonController(private val schemaProvider: DgsSchemaProvider) {
open class DgsRestSchemaJsonController(open val schemaProvider: DgsSchemaProvider) {

// The @ConfigurationProperties bean name is <prefix>-<fqn>
@RequestMapping("#{@'dgs.graphql-com.netflix.graphql.dgs.webmvc.autoconfigure.DgsWebMvcConfigurationProperties'.schemaJson.path}", produces = ["application/json"])
Expand Down
4 changes: 2 additions & 2 deletions ...se/src/main/kotlin/com/netflix/graphql/dgs/subscriptions/sse/DgsSSESubscriptionHandler.kt
View file
Open in desktop
Expand Up @@ -39,8 +39,8 @@ import java.util.*
* Do not manually extend this class.
*/
@RestController
open class DgsSSESubscriptionHandler(private val dgsQueryExecutor: DgsQueryExecutor) {
private val logger = LoggerFactory.getLogger(DgsSSESubscriptionHandler::class.java)
open class DgsSSESubscriptionHandler(open val dgsQueryExecutor: DgsQueryExecutor) {
open val logger = LoggerFactory.getLogger(DgsSSESubscriptionHandler::class.java)

@RequestMapping("/subscriptions", produces = ["text/event-stream"])
fun subscriptionWithId(@RequestParam("query") queryBase64: String): ResponseEntity<SseEmitter> {
Expand Down