Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/plugin configuration #1619

Merged
merged 42 commits into from Sep 29, 2021
Merged

Conversation

kevgliss
Copy link
Contributor

No description provided.

@kevgliss kevgliss added the enhancement New feature or request label Sep 14, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Sep 15, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Sep 15, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Sep 17, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Sep 17, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Sep 17, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Sep 20, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Sep 20, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Sep 23, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Sep 23, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Sep 27, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Sep 27, 2021
@kevgliss kevgliss marked this pull request as ready for review September 27, 2021 21:19
@lgtm-com
Copy link

lgtm-com bot commented Sep 27, 2021

This pull request fixes 1 alert when merging ef8177d into 0623e96 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

Copy link
Contributor

@mvilanova mvilanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. A few questions and things that need to be changed.

src/dispatch/plugins/dispatch_jira/plugin.py Outdated Show resolved Hide resolved
src/dispatch/plugins/dispatch_jira/plugin.py Show resolved Hide resolved
src/dispatch/plugins/dispatch_jira/plugin.py Show resolved Hide resolved
src/dispatch/plugins/dispatch_slack/config.py Outdated Show resolved Hide resolved
src/dispatch/plugins/dispatch_slack/config.py Outdated Show resolved Hide resolved
src/dispatch/plugins/dispatch_slack/config.py Outdated Show resolved Hide resolved
src/dispatch/plugins/dispatch_slack/messaging.py Outdated Show resolved Hide resolved
src/dispatch/plugins/dispatch_slack/messaging.py Outdated Show resolved Hide resolved
kevgliss and others added 8 commits September 29, 2021 11:12
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
…lack.md

Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
…lack.md

Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
@lgtm-com
Copy link

lgtm-com bot commented Sep 29, 2021

This pull request fixes 1 alert when merging 86014d7 into d16ca46 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@kevgliss kevgliss merged commit 4e8ad0b into master Sep 29, 2021
@kevgliss kevgliss deleted the enhancement/plugin-configuration branch September 29, 2021 22:51
@lgtm-com
Copy link

lgtm-com bot commented Sep 29, 2021

This pull request fixes 1 alert when merging c5ffc9e into 547cfba - view on LGTM.com

fixed alerts:

  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants