Improves data filtering reliability #2052
Conversation
|
This pull request introduces 1 alert and fixes 4 when merging cf7d8fb into 92e854d - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 1 alert when merging 162c1ce into dfd5a2f - view on LGTM.com fixed alerts:
|
|
At this point, how much of that library have we vendored in? I think at this point it might make sense to vendor in the rest and create it's own module (e.g. |
|
Roughly between 50-60% based on line count. We can look into vendoring the rest of the code in in a separate PR. |
| @@ -304,7 +304,7 @@ def get_incident_forecast( | |||
| if i == 1: | |||
| incidents = create_incident_metric_query( | |||
| db_session=db_session, | |||
| filter_spec=common['filter_spec'], | |||
| filter_spec=common["filter_spec"], | |||
There was a problem hiding this comment.
@kevgliss you may want to double check that your black plugin is running correctly.
| self.function = function | ||
| self.filters = filters | ||
|
|
||
| def get_named_models(self): |
There was a problem hiding this comment.
This func was refactored to use SortedSet()
| return cls | ||
|
|
||
|
|
||
| def get_named_models(filters): |
There was a problem hiding this comment.
This func was refactored to use []
|
This pull request fixes 1 alert when merging a91d85e into dfd5a2f - view on LGTM.com fixed alerts:
|
No description provided.