Sets response model to None for all delete endpoints to address breaking changes in FastAPI v0.80.0 #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing changes in FastAPI v0.80.0
|
This pull request fixes 1 alert when merging 5daaa2f into 41f951e - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FastAPI versions 0.80.0 or newer, the server now raises an internal server error if you are using
response_modelwith some type that doesn't includeNone, but the function is returningNone. More details here.This PR sets
response_modelfor all delete endpoints toNoneto prevent errors, and fixes some typos, docstrings, and response messages.