Enhancement/case escalation modal

[kevgliss]

Adds the ability to modify incident details before a case is escalated via a dedicated dialog.

[lgtm-com]

This pull request introduces 1 alert when merging 81b76c8 into 06a294c - view on LGTM.com

new alerts:

• 1 for Syntax error

[mvilanova]

I'll run the code locally and circle back with feedback.

[lgtm-com]

This pull request introduces 1 alert when merging d4c9a5e into 0ec5fef - view on LGTM.com

new alerts:

• 1 for Syntax error

[lgtm-com]

This pull request introduces 1 alert when merging 9d542c6 into c05ef08 - view on LGTM.com

new alerts:

• 1 for Unused import

[mvilanova]

I think showing the plugin type name and description instead of the resource name and description like before might be confusing for users.

[kevgliss]

This is technically new functionality and won't affect the current submissions, but I agree they should be the same, afaik before we had one off strings that weren't derived from anywhere. This was my attempt as generalizing them. We can either use these strings, add new ones or take the hit and make it so each reasource is rendered individually.

[mvilanova]

I think we should be consistent across the app and showing plugin info instead of resource info is confusing. When I look at the screenshot and I see the plugin title and description under incident resources it makes me think I created a plugin not a resource.

[kevgliss]

I understand, but we have to choose how we accomplish this, our options are 1) Use these strings 2) Create new strings 3) Render each resource individually. It sounds like you prefer option 3?

[mvilanova]

Yeah, I prefer # 3 as it's more clear for the user and consistent with what we already have.

[lgtm-com]

This pull request introduces 1 alert when merging 188e8ca into c05ef08 - view on LGTM.com

new alerts:

• 1 for Unused import