-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows for customizing contact information in email notifications #408
Conversation
This pull request introduces 1 alert and fixes 1 when merging 2ab61fa into 1e163bd - view on LGTM.com new alerts:
fixed alerts:
|
This pull request fixes 1 alert when merging 8cc1d8f into 1e163bd - view on LGTM.com fixed alerts:
|
src/dispatch/plugins/dispatch_google/gmail/templates/executive_report.html
Outdated
Show resolved
Hide resolved
Just so I'm clear, this PR allows you to specify a default contact ( Also, please modify the docs for the new configuration variable. Also since we are deprecating a configuration item we should first warn (in the docs and the code) that we are deprecating it for a bit before removing it. I think in this case since it's just a rename we can just alias them until we remove. |
It allows you to provide the contact information you want to use in the base template footer. In the case of the task reminder, we're using the current oncall (if |
This pull request fixes 1 alert when merging a73e631 into 1e163bd - view on LGTM.com fixed alerts:
|
No description provided.