Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows for customizing contact information in email notifications #408

Merged
merged 8 commits into from
Jun 5, 2020

Conversation

mvilanova
Copy link
Contributor

No description provided.

@mvilanova mvilanova requested a review from kevgliss June 4, 2020 22:59
@lgtm-com
Copy link

lgtm-com bot commented Jun 4, 2020

This pull request introduces 1 alert and fixes 1 when merging 2ab61fa into 1e163bd - view on LGTM.com

new alerts:

  • 1 for Potentially unsafe external link

fixed alerts:

  • 1 for Potentially unsafe external link

@lgtm-com
Copy link

lgtm-com bot commented Jun 5, 2020

This pull request fixes 1 alert when merging 8cc1d8f into 1e163bd - view on LGTM.com

fixed alerts:

  • 1 for Potentially unsafe external link

@kevgliss
Copy link
Contributor

kevgliss commented Jun 5, 2020

Just so I'm clear, this PR allows you to specify a default contact (dispatch_help) or allows you to provide a service that resolves the contact depending on when the message is sent?

Also, please modify the docs for the new configuration variable. Also since we are deprecating a configuration item we should first warn (in the docs and the code) that we are deprecating it for a bit before removing it.

I think in this case since it's just a rename we can just alias them until we remove.

@mvilanova
Copy link
Contributor Author

It allows you to provide the contact information you want to use in the base template footer. In the case of the task reminder, we're using the current oncall (if INCIDENT_ONCALL_SERVICE_ID is set), as it seems to be the best option. For all the other cases, the incident commander, so we keep discussions contained within the incident.

@mvilanova mvilanova merged commit 16a63c4 into develop Jun 5, 2020
@mvilanova mvilanova deleted the feature/email-notifications branch June 5, 2020 17:25
@lgtm-com
Copy link

lgtm-com bot commented Jun 5, 2020

This pull request fixes 1 alert when merging a73e631 into 1e163bd - view on LGTM.com

fixed alerts:

  • 1 for Potentially unsafe external link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants