Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making all plugins optional. #507

Merged
merged 16 commits into from
Jul 27, 2020
Merged

Making all plugins optional. #507

merged 16 commits into from
Jul 27, 2020

Conversation

kevgliss
Copy link
Contributor

@kevgliss kevgliss commented Jul 17, 2020

This PR makes all plugins optional. With this change, no plugin configuration will be necessary to create a new incident.

Additionally, the PR makes us much more resilient to some types of failures by remove message dependencies by ensuring that if no data is presented to a message that item is simply not rendered (as opposed to throwing an error).

@lgtm-com
Copy link

lgtm-com bot commented Jul 17, 2020

This pull request introduces 10 alerts and fixes 1 when merging 73c5aa2 into 5a80baa - view on LGTM.com

new alerts:

  • 10 for Wrong number of arguments in a call

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 17, 2020

This pull request introduces 10 alerts and fixes 1 when merging 6ecf8cf into 5a80baa - view on LGTM.com

new alerts:

  • 10 for Wrong number of arguments in a call

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 17, 2020

This pull request fixes 1 alert when merging 51ed1bd into 2fe6b90 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 17, 2020

This pull request introduces 4 alerts and fixes 1 when merging 2545f78 into c4b5224 - view on LGTM.com

new alerts:

  • 4 for Unused import

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 20, 2020

This pull request fixes 1 alert when merging 457d973 into 6324e62 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 20, 2020

This pull request fixes 1 alert when merging 4f3753d into 0825483 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 20, 2020

This pull request fixes 1 alert when merging a3f4b03 into 0825483 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 20, 2020

This pull request fixes 2 alerts when merging 27ddea4 into 0825483 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@kevgliss kevgliss marked this pull request as ready for review July 21, 2020 18:37
@kevgliss kevgliss requested a review from mvilanova July 21, 2020 18:37
@lgtm-com
Copy link

lgtm-com bot commented Jul 21, 2020

This pull request fixes 2 alerts when merging 487a6aa into 4f5da6b - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@kevgliss kevgliss merged commit c46a448 into develop Jul 27, 2020
@kevgliss kevgliss deleted the feature/optional-resources branch July 27, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant