Adds support for capturing feedback from participants on incident close #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, do you think we should provide an option (a checkbox) to give anonymous feedback? |
|
This pull request introduces 1 alert and fixes 1 when merging dda759a into f1611f8 - view on LGTM.com new alerts:
fixed alerts:
|
|
@kevgliss yeah, I think it's a good idea. We may receive more candid feedback if we provide the option. |
forestmonster
approved these changes
Oct 20, 2020
|
This pull request introduces 1 alert and fixes 1 when merging a92beaa into f1611f8 - view on LGTM.com new alerts:
fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new data model for feedback and logic to message incident participants on incident close to request them to rate and provide feedback about the incident.