Adds the ability to map/engage the liaison role. #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kevgliss
commented
Nov 10, 2020
kevgliss
commented
mvilanova
reviewed
Nov 11, 2020
src/dispatch/static/dispatch/src/incident_type/NewEditSheet.vue
Outdated
Show resolved
Hide resolved
Comment on lines
+215
to
217
| assign_incident_role( | ||
| db_session, incident, reporter_email, ParticipantRoleType.incident_commander | ||
| ) |
There was a problem hiding this comment.
nit: we could avoid passing reporting_email and use the incident reporter hybrid property inside assign_incident_role()
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
|
This pull request introduces 1 alert when merging 7bfb61f into 6f37dbf - view on LGTM.com new alerts:
|
mvilanova
reviewed
Nov 11, 2020
mvilanova
reviewed
Nov 12, 2020
mvilanova
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.