Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for header based auth. #88

Merged
merged 12 commits into from
Mar 10, 2020
Merged

Allow for header based auth. #88

merged 12 commits into from
Mar 10, 2020

Conversation

kevgliss
Copy link
Contributor

This should allow a Dispatch to be able to respect a given header as it's the source of identity.

If you are bringing your own authentication layer you can set DISPATCH_AUTH_HEADER_KEY to the email address of the user making the request. e.g. (x-amzn-oidc-identity for ALBs, https://docs.aws.amazon.com/elasticloadbalancing/latest/application/listener-authenticate-users.html)

@kevgliss kevgliss requested a review from mvilanova March 10, 2020 21:03
@kevgliss
Copy link
Contributor Author

cc @willbengtson

Copy link
Contributor

@mvilanova mvilanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kevgliss kevgliss merged commit 8f193c2 into develop Mar 10, 2020
@kevgliss kevgliss deleted the feature/disable-auth branch March 10, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants