Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nf-vertical-line doesn't handle null input, produces invalid SVG #24

Closed
jeff3dx opened this issue Apr 9, 2015 · 0 comments
Closed

nf-vertical-line doesn't handle null input, produces invalid SVG #24

jeff3dx opened this issue Apr 9, 2015 · 0 comments
Assignees
@benlesh
Labels
bug

Comments

@jeff3dx
Copy link

jeff3dx commented Apr 9, 2015

nf-vertical-line (and nf-horizontal-line) doesn't handle the case where it's x property is set to null or something non-number. This is a common case since nf-vertical-line is often bound to hoverData on another element, and hoverData is often null or undefined when the mouse is not hovering. It will produce invalid SVG resulting in this error:

Error: Invalid value for attribute y1="NaN"
@benlesh benlesh added the bug label Apr 10, 2015
@benlesh benlesh self-assigned this Apr 10, 2015
benlesh added a commit to benlesh/ember-nf-graph that referenced this issue Apr 21, 2015
@benlesh
fix Netflix#24 SVG complaints on horizontal and vertical lines when x…
a2d9c3a 
… or y values are less than or NaN
benlesh added a commit that referenced this issue Apr 21, 2015
@benlesh
Merge pull request #37 from blesh/svg_line_errors
05c0736 
fix #24 SVG complaints on horizontal and vertical lines when x or y valu...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benlesh benlesh

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benlesh @jeff3dx