Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI will build now build *all* dists, and commits (to master) #566

Merged
merged 1 commit into from
Oct 9, 2015

Conversation

sdesai
Copy link
Contributor

@sdesai sdesai commented Oct 7, 2015

So devs don't have to remember to build and commit dists with pull requests.

@ThePrimeagen
Copy link
Contributor

I love this.

@sdesai
Copy link
Contributor Author

sdesai commented Oct 9, 2015

It's my fabulous command of the English language in the title isn't it?

@falcor-build
Copy link
Contributor

Please merge it

On Thu, Oct 8, 2015, 6:12 PM Satyen Desai notifications@github.com wrote:

It's my fabulous command of the English language in the title isn't it?


Reply to this email directly or view it on GitHub
#566 (comment).

You received this message because you are subscribed to the Google Groups
"Falcor" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to falcor+unsubscribe@netflix.com.
To post to this group, send email to falcor@netflix.com.
To view this discussion on the web visit
https://groups.google.com/a/netflix.com/d/msgid/falcor/Netflix/falcor/pull/566/c146722143%40github.com
https://groups.google.com/a/netflix.com/d/msgid/falcor/Netflix/falcor/pull/566/c146722143%40github.com?utm_medium=email&utm_source=footer
.

sdesai added a commit that referenced this pull request Oct 9, 2015
CI will build now build *all* dists, and commits (to master)
@sdesai sdesai merged commit f498ee3 into Netflix:master Oct 9, 2015
@sdesai
Copy link
Contributor Author

sdesai commented Oct 9, 2015

Merged. But it seems to have some env/authentication issue in the Travis CI env so it's not committing, plus may need to pick up the branch from CI env, since the build is off a detached HEAD. I'll look at that tomorrow.

@sdesai
Copy link
Contributor Author

sdesai commented Oct 9, 2015

Seems like it's fixed. Let me know if you see anything out of line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants