Skip to content

Commit

Permalink
Relocate some classes to the new common modules
Browse files Browse the repository at this point in the history
  • Loading branch information
mprimi committed Apr 20, 2018
1 parent 5eb67e8 commit 92eefd7
Show file tree
Hide file tree
Showing 133 changed files with 381 additions and 294 deletions.
1 change: 1 addition & 0 deletions genie-agent/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ dependencies {
*******************************/

compile project(":genie-common")
compile(project(":genie-common-internal"))
compile project(":genie-proto")

// Spring
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import com.beust.jcommander.ParameterException;
import com.fasterxml.jackson.databind.JsonNode;
import com.google.common.collect.Sets;
import com.netflix.genie.common.dto.v4.Criterion;
import com.netflix.genie.common.internal.dto.v4.Criterion;
import com.netflix.genie.common.exceptions.GeniePreconditionException;
import com.netflix.genie.common.util.GenieObjectMapper;
import org.apache.commons.lang3.StringUtils;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
package com.netflix.genie.agent.cli;

import com.fasterxml.jackson.databind.JsonNode;
import com.netflix.genie.common.dto.v4.Criterion;
import com.netflix.genie.common.internal.dto.v4.Criterion;

import java.io.File;
import java.util.List;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.Lists;
import com.google.common.collect.Sets;
import com.netflix.genie.common.dto.v4.Criterion;
import com.netflix.genie.common.internal.dto.v4.Criterion;
import com.netflix.genie.common.util.GenieObjectMapper;
import lombok.Getter;
import org.springframework.stereotype.Component;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@

package com.netflix.genie.agent.cli;

import com.netflix.genie.common.dto.v4.AgentJobRequest;
import com.netflix.genie.common.dto.v4.ExecutionResourceCriteria;
import com.netflix.genie.common.dto.v4.JobMetadata;
import com.netflix.genie.common.internal.dto.v4.AgentJobRequest;
import com.netflix.genie.common.internal.dto.v4.ExecutionResourceCriteria;
import com.netflix.genie.common.internal.dto.v4.JobMetadata;
import lombok.Getter;
import org.springframework.context.annotation.Lazy;
import org.springframework.stereotype.Component;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
import com.fasterxml.jackson.databind.SerializationFeature;
import com.netflix.genie.agent.execution.exceptions.JobSpecificationResolutionException;
import com.netflix.genie.agent.execution.services.AgentJobSpecificationService;
import com.netflix.genie.common.dto.v4.AgentJobRequest;
import com.netflix.genie.common.dto.v4.JobSpecification;
import com.netflix.genie.common.internal.dto.v4.AgentJobRequest;
import com.netflix.genie.common.internal.dto.v4.JobSpecification;
import com.netflix.genie.common.util.GenieObjectMapper;
import lombok.Getter;
import lombok.extern.slf4j.Slf4j;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import com.netflix.genie.agent.execution.statemachine.States;
import com.netflix.genie.agent.execution.statemachine.actions.StateAction;
import com.netflix.genie.common.dto.JobStatus;
import com.netflix.genie.common.dto.v4.JobSpecification;
import com.netflix.genie.common.internal.dto.v4.JobSpecification;
import org.apache.commons.lang3.tuple.Triple;
import org.springframework.statemachine.action.Action;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import com.netflix.genie.agent.execution.statemachine.States;
import com.netflix.genie.agent.execution.statemachine.actions.StateAction;
import com.netflix.genie.common.dto.JobStatus;
import com.netflix.genie.common.dto.v4.JobSpecification;
import com.netflix.genie.common.internal.dto.v4.JobSpecification;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.lang3.tuple.Triple;
import org.springframework.context.annotation.Lazy;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
package com.netflix.genie.agent.execution.services;

import com.netflix.genie.agent.execution.exceptions.JobSpecificationResolutionException;
import com.netflix.genie.common.dto.v4.AgentJobRequest;
import com.netflix.genie.common.dto.v4.JobSpecification;
import com.netflix.genie.common.internal.dto.v4.AgentJobRequest;
import com.netflix.genie.common.internal.dto.v4.JobSpecification;
import org.springframework.validation.annotation.Validated;

import javax.validation.Valid;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@
import com.google.common.util.concurrent.ListenableFuture;
import com.netflix.genie.agent.execution.exceptions.JobSpecificationResolutionException;
import com.netflix.genie.agent.execution.services.AgentJobSpecificationService;
import com.netflix.genie.common.dto.v4.AgentJobRequest;
import com.netflix.genie.common.dto.v4.JobSpecification;
import com.netflix.genie.common.internal.dto.v4.AgentJobRequest;
import com.netflix.genie.common.internal.dto.v4.JobSpecification;
import com.netflix.genie.proto.GetJobSpecificationRequest;
import com.netflix.genie.proto.JobSpecificationResponse;
import com.netflix.genie.proto.JobSpecificationServiceGrpc;
import com.netflix.genie.proto.ResolveJobSpecificationRequest;
import com.netflix.genie.proto.v4.converters.JobSpecificationServiceConverter;
import com.netflix.genie.common.internal.dto.v4.converters.JobSpecificationServiceConverter;
import lombok.extern.slf4j.Slf4j;
import org.springframework.context.annotation.Lazy;
import org.springframework.stereotype.Service;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import com.netflix.genie.agent.execution.exceptions.JobLaunchException;
import com.netflix.genie.agent.execution.services.LaunchJobService;
import com.netflix.genie.agent.execution.statemachine.Events;
import com.netflix.genie.common.dto.v4.JobSpecification;
import com.netflix.genie.common.internal.dto.v4.JobSpecification;
import lombok.extern.slf4j.Slf4j;
import org.springframework.context.annotation.Lazy;
import org.springframework.stereotype.Component;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
import com.netflix.genie.agent.execution.exceptions.JobSpecificationResolutionException;
import com.netflix.genie.agent.execution.services.AgentJobSpecificationService;
import com.netflix.genie.agent.execution.statemachine.Events;
import com.netflix.genie.common.dto.v4.AgentJobRequest;
import com.netflix.genie.common.dto.v4.JobSpecification;
import com.netflix.genie.common.internal.dto.v4.AgentJobRequest;
import com.netflix.genie.common.internal.dto.v4.JobSpecification;
import com.netflix.genie.common.util.GenieObjectMapper;
import lombok.extern.slf4j.Slf4j;
import org.springframework.context.annotation.Lazy;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@
import com.netflix.genie.agent.execution.statemachine.Events;
import com.netflix.genie.agent.utils.EnvUtils;
import com.netflix.genie.agent.utils.PathUtils;
import com.netflix.genie.common.dto.v4.ExecutionEnvironment;
import com.netflix.genie.common.dto.v4.JobSpecification;
import com.netflix.genie.common.jobs.JobConstants;
import com.netflix.genie.common.internal.dto.v4.ExecutionEnvironment;
import com.netflix.genie.common.internal.dto.v4.JobSpecification;
import com.netflix.genie.common.internal.jobs.JobConstants;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.lang3.StringUtils;
import org.springframework.context.annotation.Lazy;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

package com.netflix.genie.agent.utils;

import com.netflix.genie.common.jobs.JobConstants;
import com.netflix.genie.common.internal.jobs.JobConstants;

import java.io.File;
import java.nio.file.Path;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ package com.netflix.genie.agent.cli
import com.beust.jcommander.IStringConverter
import com.beust.jcommander.ParameterException
import com.fasterxml.jackson.databind.JsonNode
import com.netflix.genie.common.dto.v4.Criterion
import com.netflix.genie.common.internal.dto.v4.Criterion
import com.netflix.genie.common.util.GenieObjectMapper
import com.netflix.genie.test.categories.UnitTest
import org.assertj.core.util.Sets
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ package com.netflix.genie.agent.cli

import com.beust.jcommander.JCommander
import com.beust.jcommander.ParametersDelegate
import com.netflix.genie.common.dto.v4.Criterion
import com.netflix.genie.common.internal.dto.v4.Criterion
import com.netflix.genie.common.util.GenieObjectMapper
import com.netflix.genie.test.categories.UnitTest
import org.junit.experimental.categories.Category
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
package com.netflix.genie.agent.cli

import com.fasterxml.jackson.databind.JsonNode
import com.netflix.genie.common.dto.v4.AgentJobRequest
import com.netflix.genie.common.dto.v4.Criterion
import com.netflix.genie.common.internal.dto.v4.AgentJobRequest
import com.netflix.genie.common.internal.dto.v4.Criterion
import com.netflix.genie.test.categories.UnitTest
import org.assertj.core.util.Sets
import org.junit.experimental.categories.Category
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ package com.netflix.genie.agent.cli
import com.fasterxml.jackson.core.JsonProcessingException
import com.netflix.genie.agent.execution.exceptions.JobSpecificationResolutionException
import com.netflix.genie.agent.execution.services.AgentJobSpecificationService
import com.netflix.genie.common.dto.v4.AgentJobRequest
import com.netflix.genie.common.dto.v4.JobSpecification
import com.netflix.genie.common.internal.dto.v4.AgentJobRequest
import com.netflix.genie.common.internal.dto.v4.JobSpecification
import com.netflix.genie.common.util.GenieObjectMapper
import org.junit.Rule
import org.junit.rules.TemporaryFolder
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ package com.netflix.genie.agent.execution
import com.netflix.genie.agent.execution.statemachine.States
import com.netflix.genie.agent.execution.statemachine.actions.StateAction
import com.netflix.genie.common.dto.JobStatus
import com.netflix.genie.common.dto.v4.JobSpecification
import com.netflix.genie.common.internal.dto.v4.JobSpecification
import com.netflix.genie.test.categories.UnitTest
import org.apache.commons.lang3.tuple.Triple
import org.junit.experimental.categories.Category
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ package com.netflix.genie.agent.execution.services.impl.grpc

import com.netflix.genie.agent.execution.exceptions.JobSpecificationResolutionException
import com.netflix.genie.agent.execution.services.AgentJobSpecificationService
import com.netflix.genie.common.dto.v4.AgentJobRequest
import com.netflix.genie.common.dto.v4.Criterion
import com.netflix.genie.common.dto.v4.ExecutionResourceCriteria
import com.netflix.genie.common.dto.v4.JobMetadata
import com.netflix.genie.common.dto.v4.JobSpecification
import com.netflix.genie.common.internal.dto.v4.AgentJobRequest
import com.netflix.genie.common.internal.dto.v4.Criterion
import com.netflix.genie.common.internal.dto.v4.ExecutionResourceCriteria
import com.netflix.genie.common.internal.dto.v4.JobMetadata
import com.netflix.genie.common.internal.dto.v4.JobSpecification
import com.netflix.genie.proto.GetJobSpecificationRequest
import com.netflix.genie.proto.JobSpecificationResponse
import com.netflix.genie.proto.JobSpecificationServiceError
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import com.netflix.genie.agent.execution.ExecutionContext
import com.netflix.genie.agent.execution.exceptions.JobLaunchException
import com.netflix.genie.agent.execution.services.LaunchJobService
import com.netflix.genie.agent.execution.statemachine.Events
import com.netflix.genie.common.dto.v4.JobSpecification
import com.netflix.genie.common.internal.dto.v4.JobSpecification
import com.netflix.genie.test.categories.UnitTest
import org.junit.experimental.categories.Category
import spock.lang.Specification
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ import com.netflix.genie.agent.execution.ExecutionContext
import com.netflix.genie.agent.execution.exceptions.JobSpecificationResolutionException
import com.netflix.genie.agent.execution.services.AgentJobSpecificationService
import com.netflix.genie.agent.execution.statemachine.Events
import com.netflix.genie.common.dto.v4.AgentJobRequest
import com.netflix.genie.common.dto.v4.ExecutionEnvironment
import com.netflix.genie.common.dto.v4.JobSpecification
import com.netflix.genie.common.internal.dto.v4.AgentJobRequest
import com.netflix.genie.common.internal.dto.v4.ExecutionEnvironment
import com.netflix.genie.common.internal.dto.v4.JobSpecification
import com.netflix.genie.common.util.GenieObjectMapper
import org.assertj.core.util.Sets
import org.junit.Rule
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ import com.netflix.genie.agent.execution.services.DownloadService
import com.netflix.genie.agent.execution.statemachine.Events
import com.netflix.genie.agent.utils.EnvUtils
import com.netflix.genie.agent.utils.PathUtils
import com.netflix.genie.common.dto.v4.ExecutionEnvironment
import com.netflix.genie.common.dto.v4.JobSpecification
import com.netflix.genie.common.jobs.JobConstants
import com.netflix.genie.common.internal.dto.v4.ExecutionEnvironment
import com.netflix.genie.common.internal.dto.v4.JobSpecification
import com.netflix.genie.common.internal.jobs.JobConstants
import com.netflix.genie.test.categories.UnitTest
import org.assertj.core.util.Sets
import org.junit.Rule
Expand Down
1 change: 1 addition & 0 deletions genie-client/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ dependencies {
*******************************/

compile project(":genie-common")
compile project(":genie-common-external")

compile("commons-beanutils:commons-beanutils")
compile("com.squareup.okhttp3:okhttp")
Expand Down
2 changes: 2 additions & 0 deletions genie-common-external/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ dependencies {
* Implementation Dependencies
*******************************/

implementation(project(":genie-common"))

/*******************************
* Provided Dependencies
*******************************/
Expand Down
5 changes: 5 additions & 0 deletions genie-common-internal/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ dependencies {
* Implementation Dependencies
*******************************/

implementation(project(":genie-common"))
implementation(project(":genie-common-external"))
implementation(project(":genie-proto"))
implementation("org.apache.commons:commons-lang3")

/*******************************
* Provided Dependencies
*******************************/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*
*/
package com.netflix.genie.common.dto.v4;
package com.netflix.genie.common.internal.dto.v4;

import com.fasterxml.jackson.annotation.JsonSetter;
import com.fasterxml.jackson.databind.JsonNode;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*
*/
package com.netflix.genie.common.dto.v4;
package com.netflix.genie.common.internal.dto.v4;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*
*/
package com.netflix.genie.common.dto.v4;
package com.netflix.genie.common.internal.dto.v4;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*
*/
package com.netflix.genie.common.dto.v4;
package com.netflix.genie.common.internal.dto.v4;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*
*/
package com.netflix.genie.common.dto.v4;
package com.netflix.genie.common.internal.dto.v4;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*
*/
package com.netflix.genie.common.dto.v4;
package com.netflix.genie.common.internal.dto.v4;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*
*/
package com.netflix.genie.common.dto.v4;
package com.netflix.genie.common.internal.dto.v4;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*
*/
package com.netflix.genie.common.dto.v4;
package com.netflix.genie.common.internal.dto.v4;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*
*/
package com.netflix.genie.common.dto.v4;
package com.netflix.genie.common.internal.dto.v4;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*
*/
package com.netflix.genie.common.dto.v4;
package com.netflix.genie.common.internal.dto.v4;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*
*/
package com.netflix.genie.common.dto.v4;
package com.netflix.genie.common.internal.dto.v4;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*
*/
package com.netflix.genie.common.dto.v4;
package com.netflix.genie.common.internal.dto.v4;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*
*/
package com.netflix.genie.common.dto.v4;
package com.netflix.genie.common.internal.dto.v4;

import com.fasterxml.jackson.annotation.JsonSetter;
import com.fasterxml.jackson.databind.JsonNode;
Expand Down
Loading

0 comments on commit 92eefd7

Please sign in to comment.