Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Save scheduler job metadata entries to env #1199

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jzhuge
Copy link
Contributor

@jzhuge jzhuge commented Feb 20, 2024

Save scheduler job metadata entries to env so that they are available for Spark run.py.

@jzhuge jzhuge changed the title Save scheduler job metadata entries to env [WIP] Save scheduler job metadata entries to env Feb 20, 2024
@jzhuge
Copy link
Contributor Author

jzhuge commented Feb 20, 2024

TODO

  • Add unit tests
  • Remove the hardcoded suffix

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a117a93) 90.75% compared to head (27ce13b) 90.75%.

Files Patch % Lines
...enie/web/services/impl/JobResolverServiceImpl.java 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1199      +/-   ##
============================================
- Coverage     90.75%   90.75%   -0.01%     
- Complexity     3809     3814       +5     
============================================
  Files           467      467              
  Lines         14976    14985       +9     
  Branches       1071     1071              
============================================
+ Hits          13591    13599       +8     
- Misses          909      910       +1     
  Partials        476      476              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant