Add digicert source plugin #4703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinmarva
requested review from
hosseinsh,
charhate,
jtschladen,
douglasc-nflx and
jmcrawford45
as code owners
| search_url = f"{base_url}/services/v2/order/certificate" | ||
|
|
||
| certs = [] | ||
| offset = 0 |
There was a problem hiding this comment.
Can we use len(certs) instead of offset? I'm concerned that the API may return less than the limit. In this case, the source plugin would skip over some certs
There was a problem hiding this comment.
"offset" is needed in the Digicert API:
https://dev.digicert.com/en/certcentral-apis/services-api.html
offset -> Index of the first result to return.
The condition to exit from the loop is:
if offset >= data["page"]["total"]:
Then no certificate would skip over
jmcrawford45
approved these changes
Nov 27, 2023
auto-merge was automatically disabled
November 27, 2023 20:43
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Digicert source plugin