-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add digicert source plugin #4703
Conversation
search_url = f"{base_url}/services/v2/order/certificate" | ||
|
||
certs = [] | ||
offset = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use len(certs) instead of offset? I'm concerned that the API may return less than the limit. In this case, the source plugin would skip over some certs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"offset" is needed in the Digicert API:
https://dev.digicert.com/en/certcentral-apis/services-api.html
offset -> Index of the first result to return.
The condition to exit from the loop is:
if offset >= data["page"]["total"]:
Then no certificate would skip over
Pull Request is not mergeable
Added Digicert source plugin