replace the metrics in HttpServerListener with Micrometer #455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Try to replace the metrics part in HttpServerListener with Micrometer metrics and wanna get some early feedback and advice.
Explanation:
In the previous implementation, we have the concepts GroupId(name, tags) and MetricId(groupname, metricname, tags).
However, in the Micrometer, it cannot name the Metrics with GroupId, so I try to add the group name as a prefix in metric name and connect them with the underscore.
If we need the group name or the metric(event) name when publishing, we can extract it from the whole metric name.
And we can still use them to form a GroupId(groupname + tags). and MetricId(metricName + tag) if needed.
Checklist
./gradlew build
compiles code correctly./gradlew test
passes all tests