Fix/cache maxsize #327
Merged
Fix/cache maxsize #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savingoyal
approved these changes
Aug 7, 2022
obgibson
approved these changes
Aug 7, 2022
There were two main issues with the current implementation:
- the size of files was considered to be the number of bytes which is
not the best for large number of small files which can happen when the
cache is dealing with artifacts (lots of small ones). The fix is to reason
based on the block size.
- there was a possibility where a file could be marked as deletable and would
then be re-created only to be then deleted again. This fix addresses this
situation.
romain-intel
force-pushed
the
fix/cache-maxsize
branch
from
dffdccf
to
d4961f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.