Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update python version #367

Merged
merged 14 commits into from
Jun 30, 2023
Merged

chore: update python version #367

merged 14 commits into from
Jun 30, 2023

Conversation

saikonen
Copy link
Collaborator

@saikonen saikonen commented Jun 22, 2023

In preparation for Python 3.7 being End-of-Life, update the Python version used for all the services Docker images

Addresses #352

TODO:

  • Figure out if the /opt/v1_0_1 setup in Dockerfile is required or not.
  • Look into why AST parsing linenumber counting changed from python 3.7 -> 3.8+
  • Update Github actions to target Python 3.11

@saikonen saikonen force-pushed the chore/update-python-version branch from ee3e4a8 to dff97dd Compare June 27, 2023 11:34
@saikonen saikonen marked this pull request as ready for review June 29, 2023 14:30
@saikonen
Copy link
Collaborator Author

still no insights on why the AST function def line numbers change, but this is not a blocker for merging as the only use on the service side is for displaying a tooltip on the Metaflow-UI DAG page. Can be looked into later in a separate PR

@saikonen saikonen merged commit 1807e38 into master Jun 30, 2023
5 checks passed
@saikonen saikonen deleted the chore/update-python-version branch June 30, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant