Add version to plugin URL to prevent caching #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for a pull request
Description of the Change
Add version to the path so that the browser cache is busted and the latest plugin is always downloaded.
Alternate Designs
A random number in the path to always bust the cache. The downside of this approach is that the HTML request would never be cached. The implemented approach will cache most of the time yet will download a new version when the version number is changed in the config for the plugin.
Possible Drawbacks
Plugin developers may not update the version number in the config.
Verification Process
Release Notes
Add version to the plugin URL to bust the cache when the version changes