Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/log search #22

Merged
merged 11 commits into from
Nov 4, 2021
Merged

Feat/log search #22

merged 11 commits into from
Nov 4, 2021

Conversation

rsanteri
Copy link
Contributor

@rsanteri rsanteri commented Nov 3, 2021

Description of the Change

Add search bar to find text from log list. Current implementation has some limitations though. It does not search from the logs user hasn't loaded to frontend yet.

Copy link
Collaborator

@saikonen saikonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log loading spinner does not seem to be working anymore when first landing on the page.

Copy link
Collaborator

@saikonen saikonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log component when fullscreened has the search row visible twice.

@romain-intel romain-intel merged commit ffaef36 into master Nov 4, 2021
@romain-intel romain-intel deleted the feat/log-search branch November 4, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants