Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:Daylight savings time not being applied for timezones #43

Merged
merged 2 commits into from
Jan 3, 2022
Merged

fix:Daylight savings time not being applied for timezones #43

merged 2 commits into from
Jan 3, 2022

Conversation

rsanteri
Copy link
Contributor

@rsanteri rsanteri commented Dec 8, 2021

Description of the Change

Fix a bug with daylight saving times. They were not applied as they should.

@rsanteri rsanteri mentioned this pull request Dec 8, 2021
Closed
@oavdeev
Copy link
Collaborator

oavdeev commented Dec 8, 2021

Since it looks like this setting is stored in the local storage as offset (not zone name), how does the following scenario work:

  1. I choose Helsinki (GMT+2) on March 1 , it gets stored in my local storage
  2. On April 1 I open the page again, but Helsinki is now (GMT+3) due to DST

Would it still show the correct time? Would it apply +2 or +3 offset?

@rsanteri
Copy link
Contributor Author

rsanteri commented Dec 9, 2021

Good point. Added fix for that

@rsanteri rsanteri merged commit e4c4c87 into master Jan 3, 2022
@rsanteri rsanteri deleted the fix/dst-not-being-applied-for-timezones branch January 3, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsanteri @oavdeev