Experiment/cards #47
Merged
Experiment/cards #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obgibson
commented
Jan 4, 2022
| const [elementHeight, setElementHeight] = useState(0); | ||
|
|
||
| // Check iframe height every second in case it changes somehow. | ||
| useEffect(() => { |
There was a problem hiding this comment.
Did you try attaching this to the iframe onload?
There was a problem hiding this comment.
I did not. That could work but I was worried about possibly changing height of the card. But then again do we want to expand iframe to cover the whole card or is it better to let scrollbar handle it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for a pull request
Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Release Notes