Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only depend on DynamoDB SDK, not on entire AWS SDK #99

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Only depend on DynamoDB SDK, not on entire AWS SDK #99

merged 1 commit into from
Apr 6, 2018

Conversation

amcp
Copy link
Contributor

@amcp amcp commented Apr 6, 2018

Fixes #98

@ipapapa ipapapa merged commit eb2d31c into Netflix:master Apr 6, 2018
@ipapapa
Copy link
Contributor

ipapapa commented Apr 6, 2018

This is really good. What bothers me with the DDB DAX library is that it is not yet integrated with the SDK. Hence we have to do funky stuff to get it downloaded and built like:

https://github.com/Netflix/ndbench/blob/master/ndbench-dynamodb-plugins/build.gradle#L8-L20

It causes the issues #91 (effectively ./gradlew clean build does not work but ./gradlew clean & ./gradlew build works. One way to solve is to include the .jar inside the NDBench repo but this is a bad approach as new updates will require re-uploading a new .jar.

Any thoughts on how to fix that.

@ipapapa ipapapa self-requested a review April 6, 2018 18:08
@ipapapa ipapapa mentioned this pull request Apr 6, 2018
Merged
ipapapa added a commit that referenced this pull request Apr 7, 2018
@ipapapa
Fix loading Modules (#95)
e597766 
* Geode plugin naming convention

* Janusgraph plugin naming convention

* Fixing DynamoDB and EVCache reflection

* Upgrading Gradle to 4.6 (#94)

* Fix missing license headers (#96)

* Only depend on DynamoDB SDK, not on entire AWS SDK (#99)

* Fixes #98

* Updating order of plugins based on @amcp feedback.

* Replacing `System.out.println` with Logger.

* Spelling mistake as reported in #100
@amcp amcp deleted the fixSdk branch April 8, 2018 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipapapa ipapapa Awaiting requested review from ipapapa

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amcp @ipapapa