Fix loading Modules #95
Conversation
| @@ -96,4 +96,11 @@ | |||
| @DefaultValue("xxx:8111") | |||
| String getDaxEndpoint(); | |||
|
|
|||
|
|
|||
| @PropertyName(name = "AWSAccessKey") | |||
There was a problem hiding this comment.
Using application.properties means that the credentials have to go into a file curated by this project. Could we use DefaultCredentialProviderChain, so that if run on managed compute, credentials get pulled from the instance profile, and otherwise get pulled from environment variables?
There was a problem hiding this comment.
Right, we are also picking up the credentials from the instance profile. This seems to be breaking our internal deployment as well. I will into how to use DefaultCredentialProviderChain.
There was a problem hiding this comment.
lets make an issue to fix credentials later
There was a problem hiding this comment.
I have been using the plugin for some time now and this breaks our internal bindings with AWSCredentials. To move forward with the rest of your work, I will merge it and will revisit on Monday.
| @@ -12,6 +12,9 @@ dependencies { | |||
| compile project(':ndbench-es-plugins') | |||
There was a problem hiding this comment.
minor: I would opt to order this list of plugins in alphabetical order, so it is easier to spot missing dependencies in the future.
JanusGraphandGeodeplugins naming convention consistentSystem.out.printlnwithLoggeroutput when necessary.