Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapter-puppeteer): Remove other resource type matching #197

Merged
merged 1 commit into from Apr 9, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions CONTRIBUTING.md
Expand Up @@ -40,6 +40,16 @@ This will bootstrap & build the packages, stand up the node test server, and
instantiate testem. Once running, the test suite will be rerun when any changes
are made to the src or test files.

## Running Node Tests with Chrome Inspector

To run the node test suite with node inspector support, run from the root directory:

```bash
yarn test:ci -l Node:debug
```

Next, attach Chrome to the running process by visiting [chrome://inspect/#devices](chrome://inspect/#devices)

## Running Docs

All the documentation can be found in the root level `docs` directory. Running
Expand Down
2 changes: 2 additions & 0 deletions docs/adapters/puppeteer.md
Expand Up @@ -6,6 +6,8 @@ you to get the full power of Polly and Puppeteer.

## Installation

?> **NOTE** If you're using Puppeteer 1.7 or 1.8, you'll experience issues using passthrough requests. Please upgrade to the latest version of Puppeteer or use a version prior to 1.7.

_Note that you must have node (and npm) installed._

```bash
Expand Down
2 changes: 2 additions & 0 deletions packages/@pollyjs/adapter-puppeteer/README.md
Expand Up @@ -12,6 +12,8 @@ to be used with `@pollyjs/core`.

## Installation

_If you're using puppeteer 1.7 or 1.8, you'll experience issues with passthrough requests. Please upgrade to the latest version of puppeteer or use a version prior to 1.7_

_Note that you must have node (and npm) installed._

```bash
Expand Down
4 changes: 1 addition & 3 deletions packages/@pollyjs/adapter-puppeteer/src/index.js
Expand Up @@ -13,9 +13,7 @@ export default class PuppeteerAdapter extends Adapter {
get defaultOptions() {
return {
page: null,

/* NOTE: `"other" is needed as of puppeteer 1.7.0 to capture the passthrough request */
requestResourceTypes: ['xhr', 'fetch', 'other']
requestResourceTypes: ['xhr', 'fetch']
};
}

Expand Down
3 changes: 3 additions & 0 deletions testem.js
Expand Up @@ -35,6 +35,9 @@ module.exports = {
},
middleware: [attachMiddleware],
launchers: {
'Node:debug': {
command: 'yarn test:node --inspect-brk'
},
Node: {
command: 'yarn test:node --reporter tap',
protocol: 'tap'
Expand Down