Add client port config override #65
Conversation
ghost
assigned 
|
ribbon-pull-requests #58 SUCCESS |
| shouldUseOverridePort = true; | ||
|
|
||
| }else{ | ||
| logger.warn("%s set to force client port but no secure port is set, so ignoring", clientName); |
There was a problem hiding this comment.
I don't think "%s" works here. Should be "{}".
There was a problem hiding this comment.
My bad. I have a bunch of these -- I'll just replace it with string concat.
|
An alternative solution would be adding this logic to DiscoveryEnabledNIWSServerList.obtainServersViaDiscovery(). This will enable us to solve both internal and external requirements in one place. |
I like this idea -- I'll go ahead and put the logic there. |
|
ribbon-pull-requests #60 SUCCESS |
|
ribbon-pull-requests #61 SUCCESS |
| */ | ||
| @RunWith(PowerMockRunner.class) | ||
| @PrepareForTest( {DiscoveryManager.class, DiscoveryClient.class} ) | ||
| @PowerMockIgnore("javax.management.*") |
There was a problem hiding this comment.
|
Thanks for taking the extra step to mock out the Discovery APIs! |
Add client port config override
I will also let this propagate through the ecosystem before referencing the new enum in other packages.
This can be a temporary feature until completion of Netflix/eureka#71