Allow AtlasMetricObserver to be stopped #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AtlasMetricObserver` creates a thread to push metrics to the backend. It now adds a new method, `stop`, so the thread can be cleaned up.
brharrington
approved these changes
Aug 4, 2017
| * Stop attempting to send metrics to atlas. | ||
| * Cleans up the thread that is created by this observer. | ||
| */ | ||
| public void stop() { |
There was a problem hiding this comment.
Do you think this should be part of the base observer interface? It seems like other observer types might hit the same problem. I think we could use a default method with an empty implementation to avoid breaking compatibility.
There was a problem hiding this comment.
It's probably a good idea to add it to the base interface. I'll create a new PR with that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtlasMetricObservercreates a thread to push metrics to the backend.It now adds a new method,
stop, so the thread can be cleaned up.