Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Switch to filtering DescribeNetworkInterfaces based on AZs, not VPCs #166

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

sargun
Copy link
Contributor

@sargun sargun commented Aug 17, 2018

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1869

  • 0 of 51 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 23.888%

Changes Missing Coverage Covered Lines Changed/Added Lines %
vpc/ec2wrapper/ec2metadata.go 0 6 0.0%
vpc/globalgc/globalgc.go 0 45 0.0%
Files with Coverage Reduction New Missed Lines %
vpc/globalgc/globalgc.go 2 0.0%
Totals Coverage Status
Change from base Build 1860: -0.1%
Covered Lines: 2288
Relevant Lines: 9578

💛 - Coveralls

@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #166 into master will decrease coverage by 0.16%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
- Coverage   33.73%   33.56%   -0.17%     
==========================================
  Files          63       63              
  Lines        7551     7588      +37     
==========================================
  Hits         2547     2547              
- Misses       4697     4734      +37     
  Partials      307      307
Impacted Files Coverage Δ
vpc/globalgc/globalgc.go 0% <0%> (ø) ⬆️
vpc/ec2wrapper/ec2metadata.go 0% <0%> (ø) ⬆️

@sargun sargun merged commit b5c334d into master Aug 17, 2018
@sargun sargun deleted the fix-globalgc branch August 17, 2018 01:50
@fabiokung
Copy link
Contributor

LGTM

A followup PR to remove commented code and remove the vpcID param would be good once we determine that this fixes the issue with filtering Describes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants