This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Make titus mount use new patchset #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
- Coverage 31.54% 31.43% -0.11%
==========================================
Files 66 66
Lines 8407 8401 -6
==========================================
- Hits 2652 2641 -11
- Misses 5435 5439 +4
- Partials 320 321 +1
|
rgulewich
reviewed
Oct 16, 2018
| @@ -1405,7 +1400,7 @@ const ( | |||
| ) | |||
|
|
|||
| func (r *DockerRuntime) setupEFSMounts(parentCtx context.Context, c *runtimeTypes.Container, rootFile *os.File, cred *ucred, efsMountInfos []efsMountInfo) error { | |||
| baseMountOptions := []string{"nofsc,nosharecache,vers=4"} | |||
| baseMountOptions := []string{"vers=4.1,nosharecache,rsize=1048576,wsize=1048576,timeo=600,retrans=2,noresvport"} | |||
There was a problem hiding this comment.
What's the reason for the other new mount options?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This uses this patched kernel:
Netflix-Skunkworks/linux@26d791f