Only capture the first failure state in passport future listener #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinbunney
requested review from
sullis,
jguerra,
kyagna,
AlexanderEllis and
artgon
artgon
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During large content streams, if a client cancels a request mid-stream, the
ChannelPromisewill fire failed events for each chunk queued to be written to theChannelOutboundHandlerAdapter. This can cause a huge amount ofPassportState.OUT_REQ_CONTENT_ERROR_SENDINGto be added to the passport.This PR will only add the first failure state for passport state listeners, which will ensure that only the first
OUT_REQ_CONTENT_ERROR_SENDINGis logged against the passport, with others being dropped.