Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only capture the first failure state in passport future listener #1347

Merged
merged 1 commit into from Oct 19, 2022
Merged

Only capture the first failure state in passport future listener #1347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions zuul-core/src/main/java/com/netflix/zuul/netty/insights/PassportStateListener.java
View file
Open in desktop
Expand Up @@ -48,8 +48,12 @@ public void operationComplete(Future future) throws Exception
passport.add(successState);
}
else {
if (failState != null)
passport.add(failState);
if (failState != null) {
// only capture a single failure state event,
// as sending content errors will fire for all content chunks,
// and we only need the first one
passport.addIfNotAlready(failState);
}
}
}
}