Adjust retry policy before checking isBelowRetryLimit #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguerra
requested review from
gavinbunney,
argha-c,
karim-z,
kyagna and
lindseyreynolds
gavinbunney
approved these changes
May 8, 2024
argha-c
requested changes
May 8, 2024
| if ((isBelowRetryLimit()) && (isRetryable(err))) { | ||
| boolean retryable = isRetryable(err); | ||
| if (retryable) { | ||
| origin.adjustRetryPolicyIfNeeded(zuulRequest); |
There was a problem hiding this comment.
The adjustment itself is fine.
The issue here is currently this is going to throw off retries disabled metrics, regardless of whether or not the limit was reached. We need to split that part from the adjustment, as part of this change since it's inaccurate otherwise. (for internal usages not oss)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.