[zuul-core] Replace http only channel initializer with ALPN based #932
Conversation
argha-c
changed the title
|
This is a breaking change and could impact users that don't want to run SSL-based servers. EDIT: also breaks use cases that don't want/need ALPN/HTTP2 |
| @@ -51,18 +51,6 @@ | |||
| private final SwallowSomeHttp2ExceptionsHandler swallowSomeHttp2ExceptionsHandler; | |||
| private final String metricId; | |||
|
|
|||
|
|
|||
| /** | |||
| * Use {@link #Http2SslChannelInitializer(String, ChannelConfig, ChannelConfig, ChannelGroup)} instead. | |||
There was a problem hiding this comment.
The reason this is deprecated (and not deleted) is because this is a backward incompatible change.
There was a problem hiding this comment.
Well, the reason we deprecate is to eventually be able to remove.
I see this was only deprecated recently. We should probably make the deprecation window explicit.
There was a problem hiding this comment.
Yeah, I would cut a minor release, then probably make this change. It's not actually semver, but it's enough to be able to upgrade.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
This enforces SSL based initialization, with ALPN based swapping of the appropriate protocol handlers.
Edit: This is likely a breaking change, for those relying on the non-SSL based http only initializer today.