Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenVPN server network validator #5736

Closed
filippocarletti opened this issue Mar 21, 2019 · 5 comments
Closed

OpenVPN server network validator #5736

filippocarletti opened this issue Mar 21, 2019 · 5 comments
Labels
bug A defect of the software verified All test cases were verified successfully
Projects
NethServer 7

Comments

@filippocarletti
Copy link
Member

The OpenVPN Network validator wrongly assumes that the fourth octet is always 0.

Steps to reproduce

  • Insert 172.31.4.240 in OpenVPN->Server->Network
  • Save configuration

Expected behavior

Save success, network is valid

Actual behavior

Error: Network regular expression /^(([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5]).){3}(0)$/

Components

nethserver-openvpn-1.7.2-1.ns7.noarch
See also

https://community.nethserver.org/t/subnet-refused-by-gui/12310

Thanks to pike (Michael Kicks)
@filippocarletti filippocarletti added the bug A defect of the software label Mar 21, 2019
@filippocarletti filippocarletti added this to ✋ Needs review in NethServer 7 via automation Mar 21, 2019
@filippocarletti
Copy link
Member Author

Workaround:

config setprop openvpn@host-to-net Network 172.31.4.240
signal-event nethserver-openvpn-save

@gsanchietti gsanchietti mentioned this issue Mar 25, 2019
Merged
gsanchietti added a commit to NethServer/nethserver-openvpn that referenced this issue Mar 25, 2019
@gsanchietti
UI: improve network validator (#46)
bb990dd 
- network and netmask must be consistent
- netmask must be lower or equal than 255.255.255.248

NethServer/dev#5736
@gsanchietti
Copy link
Member

Test case

  • Check the bug is not reproducible.
  • Check the UI doesn't accept a netmask bigger than 255.255.255.248, otherwise OpenVPN will not start

@nethbot
Copy link
Member

nethbot commented Mar 25, 2019

in 7.6.1810/testing:

@gsanchietti gsanchietti added the testing Packages are available from testing repositories label Mar 25, 2019
@gsanchietti
Copy link
Member

Verified by pike.

@gsanchietti gsanchietti added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Mar 26, 2019
@nethbot
Copy link
Member

nethbot commented Mar 26, 2019

in 7.6.1810/updates:

NethServer 7 automation moved this from ✋ Needs review to 🗑 Done Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect of the software verified All test cases were verified successfully
Projects
No open projects
NethServer 7
🗑 Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@filippocarletti @gsanchietti @nethbot