Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rspamd: deleting a rule always delete latest #5951

Closed
federicoballarini opened this issue Nov 22, 2019 · 8 comments
Closed

Rspamd: deleting a rule always delete latest #5951

federicoballarini opened this issue Nov 22, 2019 · 8 comments
Labels
bug A defect of the software verified All test cases were verified successfully

Comments

@federicoballarini
Copy link
Member

Steps to reproduce

  • Login into Cockpit interface
  • Go to Email > Filters page
  • Add 4 rules
  • Try to delete one rules (not last in the list)

Expected behavior

  • Rules is deleted

Actual behavior

  • The deleted rules is the last in the list

Components

nethserver-mail
nethserver-cockpit
@federicoballarini federicoballarini added the bug A defect of the software label Nov 22, 2019
@federicoballarini federicoballarini mentioned this issue Nov 22, 2019
Closed
@federicoballarini
Copy link
Member Author

Fixed with this PR NethServer/nethserver-mail#164

@DavidePrincipi DavidePrincipi self-assigned this Nov 25, 2019
@DavidePrincipi DavidePrincipi removed their assignment Nov 25, 2019
@DavidePrincipi
Copy link
Member

Bug confirmed!

API exec: nethserver-mail/filter/update
$  echo '{"action":"rule","props":{"SenderBlackList":[],"SenderWhiteList":["first@nethesis.it","second@nethesis.it","third@nethesis.it"],"RecipientWhiteList":[]}}' | /usr/bin/sudo /usr/libexec/nethserver/api/nethserver-mail/filter/update | jq

So "fourth" disappeared, but I want to remove "second"...

@federicoballarini federicoballarini mentioned this issue Nov 25, 2019
Merged
@federicoballarini
Copy link
Member Author

@DavidePrincipi I opened a new PR only for this problem. I think it can be reviewed.

DavidePrincipi pushed a commit to NethServer/nethserver-mail that referenced this issue Nov 25, 2019
@federicoballarini @DavidePrincipi
ui. fix rules removal problem (#165)
c5bc737 
NethServer/dev#5951
@DavidePrincipi DavidePrincipi added the testing Packages are available from testing repositories label Nov 25, 2019
@nethbot
Copy link
Member

nethbot commented Nov 25, 2019

in 7.7.1908/testing:

@DavidePrincipi DavidePrincipi added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Nov 26, 2019
@DavidePrincipi
Copy link
Member

Blocked by #5940

@DavidePrincipi DavidePrincipi mentioned this issue Nov 26, 2019
Closed
1 task
@nethbot
Copy link
Member

nethbot commented Nov 27, 2019

in 7.7.1908/testing:

@nethbot
Copy link
Member

nethbot commented Nov 29, 2019

in 7.7.1908/testing:

DavidePrincipi pushed a commit to NethServer/nethserver-mail that referenced this issue Dec 2, 2019
@federicoballarini @DavidePrincipi
ui. fix rules removal problem (#165)
d9eed24 
NethServer/dev#5951
@nethbot
Copy link
Member

nethbot commented Dec 2, 2019

in 7.7.1908/updates:

@NethServer NethServer deleted a comment from nethbot Dec 2, 2019
@DavidePrincipi DavidePrincipi mentioned this issue Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect of the software verified All test cases were verified successfully
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DavidePrincipi @federicoballarini @nethbot