Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing delegation UI with remote account provider #6023

Closed
stephdl opened this issue Jan 10, 2020 · 9 comments
Closed

Missing delegation UI with remote account provider #6023

stephdl opened this issue Jan 10, 2020 · 9 comments
Labels
bug A defect of the software verified All test cases were verified successfully

Comments

@stephdl
Copy link

stephdl commented Jan 10, 2020

Steps to reproduce

  • Bound a Nethserver 7 to a remote authentificator, openldap or Samba AD
  • You can delegate some permissions on the server running the user account provider
  • You cannot delegate on the bound server because the group field in the user/group panel is not editable.

Expected behavior

The storage of permission is local on the server, under cockpit.socket{'delegations'}, I expect that on the bound server I could delegate some permissions to the groups I want like I could do when the server gets an account provider locally

Actual behavior

The bound server cannot be delegated, only members of domain admins group and root can do most of everything

Components

nethserver-cockpit

Additional information

The current authorize group screenshot:

image

@stephdl stephdl added the bug A defect of the software label Jan 10, 2020
@DavidePrincipi DavidePrincipi changed the title Cockpit: No delegations with remote authentification Missing delegation UI with remote account provider Jan 13, 2020
stephdl added a commit to NethServer/nethserver-cockpit that referenced this issue Feb 6, 2020
Roles and edit buttons are separated NethServer/dev#6023
@nethbot
Copy link
Member

nethbot commented Feb 6, 2020

in 7.7.1908/testing:

@stephdl
Copy link
Author

stephdl commented Feb 6, 2020

QA

The test must be done between two servers with a local and a remote authentication, the goal is to have a separated modal for delegation_edit and group_edit/creation.

  • on local authentication the button is under the kebab widget
  • on remote authentication the button is visible on the group list

all group creation/edit and delegation edit must be workable

@stephdl stephdl removed their assignment Feb 6, 2020
@stephdl stephdl added the testing Packages are available from testing repositories label Feb 6, 2020
@DavidePrincipi DavidePrincipi removed the testing Packages are available from testing repositories label Feb 7, 2020
@DavidePrincipi
Copy link
Member

DavidePrincipi commented Feb 7, 2020

It seems there's still "Terminal" displayed among the system modules for group "Domain Admins". Can we remove it?

image

⚠️ The wording Make sure delegated users have the "Shell" option enabled. should be removed with the new ShellOverrideStatus=enabled. We can remove it here IMO, unconditionally. What do you think @gsanchietti @stephdl ?

@stephdl
Copy link
Author

stephdl commented Feb 7, 2020

Until the option is not available in the UI, or a default option for every body it will lead to issue. Even for the admin user it raises from time to time some questions on the community

But here now the message must be

Make sure delegated users have the "Shell" option enabled or the shell override enabled.

stephdl added a commit to NethServer/nethserver-cockpit that referenced this issue Feb 10, 2020
translation: remove the shell need for users NethServer/dev#6023
@nethbot
Copy link
Member

nethbot commented Feb 10, 2020

in 7.7.1908/testing:

@stephdl
Copy link
Author

stephdl commented Feb 10, 2020

  • Reminder to push translations

@nethbot
Copy link
Member

nethbot commented Feb 11, 2020

in 7.7.1908/testing:

@DavidePrincipi DavidePrincipi added the testing Packages are available from testing repositories label Feb 11, 2020
@DavidePrincipi
Copy link
Member

VERIFIED

The new dialog is available with both local and remote accounts provider.

Tested with OpenLDAP.

@DavidePrincipi DavidePrincipi removed their assignment Feb 11, 2020
@DavidePrincipi DavidePrincipi removed the testing Packages are available from testing repositories label Feb 11, 2020
@DavidePrincipi DavidePrincipi added the verified All test cases were verified successfully label Feb 11, 2020
@nethbot
Copy link
Member

nethbot commented Feb 11, 2020

in 7.7.1908/updates:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect of the software verified All test cases were verified successfully
Projects
None yet
Development

No branches or pull requests

3 participants