Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate ssh/sftp to all users #219

Closed
wants to merge 2 commits into from
Closed

Conversation

stephdl
Copy link
Contributor

@stephdl stephdl commented Feb 11, 2020

@nethbot
Copy link
Member

nethbot commented Feb 11, 2020

in 7.7.1908/autobuild:

Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this minimal change approach! It surely works in most of our use cases.

However it has a limitation with remote LDAP account providers. You are assuming there is a locals group, but the users primary group can be named differently.

This limitation is not present with AD because it has a well defined structure and builtin entries like "domain users". There should always be a "domain users" group: we can assume it exists.

As alternative, how much is it complex to implement an abstract "Everyone" group? I guess a Match All line in sshd_config can do the job... Maybe it requires also some UI changes.

@stephdl
Copy link
Contributor Author

stephdl commented Feb 12, 2020

well if you want a match all, I think that * is for us, we have no brain to calculate whatever the group name...

What do you think ?

@nethbot
Copy link
Member

nethbot commented Feb 12, 2020

in 7.7.1908/autobuild:

@DavidePrincipi
Copy link
Member

Is this PR still required? Can we close it?

@stephdl
Copy link
Contributor Author

stephdl commented Feb 14, 2020

set closed obsoleted by #220

@stephdl stephdl closed this Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants