Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI allow Everyone to SSH #220

Merged
merged 7 commits into from
Feb 25, 2020
Merged

UI allow Everyone to SSH #220

merged 7 commits into from
Feb 25, 2020

Conversation

stephdl
Copy link
Contributor

@stephdl stephdl commented Feb 13, 2020 •
edited

@nethbot
Copy link
Member

nethbot commented Feb 13, 2020

in 7.7.1908/autobuild:

@stephdl stephdl mentioned this pull request Feb 14, 2020
Closed
@nethbot
Copy link
Member

nethbot commented Feb 14, 2020

in 7.7.1908/autobuild:

@stephdl stephdl marked this pull request as ready for review February 14, 2020 15:39
DavidePrincipi
DavidePrincipi reviewed Feb 17, 2020
View reviewed changes
Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As "Administrators are always granted SSH and SFTP access", the AccessEveryone is actually applied to normal users only.

I wonder if we can make the UI more self-explanatory (and less verbose) by showing the "admin/group" and its default ssh+sftp permission below the groups selector.

  • The item could be in a "read-only" state, as the policy is hardcoded.
  • The root user does not need to be listed, as it already has a dedicated checkbox to enable/disable SSH access for him.

ui/public/i18n/language.json Outdated Show resolved Hide resolved
ui/public/i18n/language.json Outdated Show resolved Hide resolved
stephdl and others added 2 commits February 24, 2020 16:22
@stephdl @DavidePrincipi
Update ui/public/i18n/language.json
6b5bff9 
Co-Authored-By: Davide Principi <davide.principi@nethesis.it>
@stephdl @DavidePrincipi
Update ui/public/i18n/language.json
199e997 
Co-Authored-By: Davide Principi <davide.principi@nethesis.it>
@nethbot
Copy link
Member

nethbot commented Feb 24, 2020

in 7.7.1908/autobuild:

1 similar comment
@nethbot
Copy link
Member

nethbot commented Feb 24, 2020

in 7.7.1908/autobuild:

@stephdl
Copy link
Contributor Author

stephdl commented Feb 24, 2020

@DavidePrincipi
Screenshot

@nethbot
Copy link
Member

nethbot commented Feb 24, 2020

in 7.7.1908/autobuild:

@stephdl stephdl merged commit 1cbe917 into NethServer:master Feb 25, 2020
@stephdl stephdl deleted the GH6059Everyone branch February 25, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidePrincipi DavidePrincipi DavidePrincipi approved these changes

Assignees

@stephdl stephdl

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@stephdl @nethbot @DavidePrincipi