Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable SIP & H323 in Shorewall #165

Merged
merged 6 commits into from
Nov 6, 2020
Merged

Disable SIP & H323 in Shorewall #165

merged 6 commits into from
Nov 6, 2020

Conversation

stephdl
Copy link
Contributor

@stephdl stephdl commented Oct 30, 2020 •
edited
Loading

You can experiment some issues with shorewall and asterisk if shorewall drops some packets : https://shorewall.org/FAQ.htm#faq77

see for explanation
https://en.wikipedia.org/wiki/Application-level_gateway

NethServer/dev#6326

@stephdl stephdl marked this pull request as draft October 30, 2020 15:55
@stephdl stephdl force-pushed the disableSipAlg branch 4 times, most recently from c4ac4d0 to 304148c Compare November 2, 2020 17:00
@nethbot
Copy link
Member

nethbot commented Nov 2, 2020

in 7.8.2003/autobuild:

@NethServer NethServer deleted a comment from nethbot Nov 2, 2020
@NethServer NethServer deleted a comment from nethbot Nov 2, 2020
@NethServer NethServer deleted a comment from nethbot Nov 2, 2020
@stephdl stephdl marked this pull request as ready for review November 2, 2020 17:20
gsanchietti
gsanchietti reviewed Nov 3, 2020
View reviewed changes
createlinks Outdated Show resolved Hide resolved
root/etc/e-smith/events/actions/nethserver-firewall-base-rmmod-SipH323-modules Outdated Show resolved Hide resolved
api/settings/read Show resolved Hide resolved
@nethbot
Copy link
Member

nethbot commented Nov 4, 2020

in 7.8.2003/autobuild:

gsanchietti
gsanchietti requested changes Nov 6, 2020
View reviewed changes
Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor rewording

ui/public/i18n/language.json Outdated Show resolved Hide resolved
ui/public/i18n/language.json Outdated Show resolved Hide resolved
ui/public/i18n/language.json Outdated Show resolved Hide resolved
@stephdl @gsanchietti
Review of translation
d913fe9 
Co-authored-by: Giacomo Sanchietti <giacomo.sanchietti@nethesis.it>
@NethServer NethServer deleted a comment from nethbot Nov 6, 2020
@NethServer NethServer deleted a comment from nethbot Nov 6, 2020
@nethbot
Copy link
Member

nethbot commented Nov 6, 2020

in 7.8.2003/autobuild:

@stephdl stephdl merged commit df59f7b into NethServer:master Nov 6, 2020
@stephdl stephdl deleted the disableSipAlg branch November 6, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsanchietti gsanchietti gsanchietti approved these changes

@cotosso cotosso Awaiting requested review from cotosso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephdl @nethbot @gsanchietti