Map unification into SlottedArray #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimum allowed line rate is |
Scooletz
added
🐌 performance
This was referenced Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the previously introduced
HashingMap, unifying all the maps into a singleSlottedArraycomponent.Beside unification, it also simplifies the implementation by introducing the hash-based behavior. This has some impact on the size, as entries will not have initial nibbles extracted to the
Slot.Prefix, but overall should increase readability and simplicity of the implementation. Additionally, hash based addressing, should have much smaller number of collisions.The last bust not least, this PR introduces
NibblePath.GetHashCodewith some benchmarks. This is the actual hashing mechanism used for storing data in the database.Warning: it makes the db BIG for now