-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importer #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💾 disk size
A change makes the disk size smaller
ethereum
An Ethereum specific work item that requires a good understanding of Eth
🌴Merkle
Merkle construct
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces and
Importer
that does the import fromRocksDb
ofNethermind
into Paprika's custom storage. To make it work it introduces the following changes:Key
away from thePagedDb
SlottedArray
is now based or rawReadOnlySpan<byte>
keyStoreKey
that allows to efficiently encodeKey
into aSpan<byte>
wrapping structurePagedDb
.Node.Branch
that is full will have its value encoded as one byte instead of 3. This is a small improvement but should provide some space in upper layers of thePagedDb
tree.IBatchContext
& co. allows now pages to beRegisterForFutureReuse
. Whenever a page is no longer needed it can be abandoned with this call without leaking it out.DataPage
has the biggest change introduced withLeaf
pages. Whenever the internal map of the page is full but it has no nibble children, it won't have the biggest nibble flushed first. It will use the buckets for addresses to create more pages with maps until they are full. Only once they are full they will be flushed down. This single change reduced the Sepolia size by 40%-50%. Should be observed withMainnet
.Closes #156