Merkle foundations with pre-commit hook #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scooletz
added
the
ethereum
Minimum allowed line rate is |
emlautarom1
reviewed
Jun 19, 2023
| @@ -417,6 +424,8 @@ private void Set(in Key key, in ReadOnlySpan<byte> payload) | |||
| map.TrySet(key, payload); | |||
| } | |||
|
|
|||
| public IKeyEnumerator GetEnumerator() => throw new NotImplementedException("Not implemented yet"); | |||
There was a problem hiding this comment.
If Block is responsible for keeping track of the keys used, could we face performance issues?
emlautarom1
reviewed
Jun 19, 2023
| @@ -391,7 +396,9 @@ public void SetStorage(in Keccak key, in Keccak address, UInt256 value) | |||
| Set(Key.StorageCell(path, address), payload); | |||
| } | |||
|
|
|||
| private void Set(in Key key, in ReadOnlySpan<byte> payload) | |||
| public bool TryGet(in Key key, out ReadOnlySpanOwner<byte> result) => throw new NotImplementedException("Not implemented yet"); | |||
There was a problem hiding this comment.
We already have a Get method, why do we need a TryGet?
There was a problem hiding this comment.
This is a subject to debate what to do on the missing one. I assume for now that you'd like to know that it was not there 👀
emlautarom1
approved these changes
Jun 19, 2023
|
Merge at will @emlautarom1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a seam for the place where
Merkleconstruct will be created. It is done in a way, so thatVerkleconstruct in a future should be also easy to inject into it as a similar, but separate, implementation. The implementation in theblockchainis not done yet, but it should not prevent users from using the seam.Effectively, this allows to implement the Merkle construct as